Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add history line when changing the review deadline. (fixes #6598) #7194

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

kivinen
Copy link
Contributor

@kivinen kivinen commented Mar 16, 2024

Add history line when the review deadline is changed. Also fixes the subject line of the email sent out, so if there is no specific revision requested it does not print the extra "-" at the end.

Subject used to look:

Subject: Deadline changed: Secdir last call review of draft-ietf-opsawg-9092-update-

now it will look:

Subject: Deadline changed: Secdir last call review of draft-ietf-opsawg-9092-update

ietf/doc/views_review.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.94%. Comparing base (187c2c5) to head (7a15257).
Report is 59 commits behind head on main.

Files Patch % Lines
ietf/doc/views_review.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7194      +/-   ##
==========================================
- Coverage   88.98%   88.94%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41067     +350     
==========================================
+ Hits        36233    36526     +293     
- Misses       4484     4541      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 79416cf into ietf-tools:main Mar 21, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants