feat: API to replace email alias generation commands #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encapsulates logic from generate_draft_aliases.py
Stolen from feat/rpc-api
Parses output from the draft_aliases API call
rjsparks
previously approved these changes
Feb 2, 2024
This comment was marked as spam.
This comment was marked as spam.
The test was incorrect - and fails when fixed. :-(
Test currently fails
I *think* this must be what had been intended. The code does not look like it ever dealt with GroupHistory, so I'm pretty sure it wasn't meant to have the same acronym used by two different Groups at different times.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7012 +/- ##
==========================================
+ Coverage 88.92% 88.97% +0.05%
==========================================
Files 289 291 +2
Lines 40454 40710 +256
==========================================
+ Hits 35972 36223 +251
- Misses 4482 4487 +5 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the API endpoints and script needed to remove email alias management commands from Cron-runner