feat: celery tasks to replace ietf/bin scripts #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My linter does not like variables defined outside of __init__()
Calls idindex generation functions and does the file update dance to put them in place.
More testable this way
yay testing
Not sure this is the right thing to do, but it's the same as rfc_editor_index_update_task
This matches the crontab file field order
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6971 +/- ##
==========================================
+ Coverage 88.92% 88.94% +0.02%
==========================================
Files 289 291 +2
Lines 40454 40577 +123
==========================================
+ Hits 35972 36091 +119
- Misses 4482 4486 +4 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds celery tasks that implement most of the scripts called by
bin/hourly,bin/daily, etc.It still remains to do the same for management commands (in addition to tackling
Night-runnerandCron-runner, of course).Cutting this off here to get feedback on something approaching a reasonable chunk - though probably already a bit big for that purpose.