Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Avoid module-level queries #6916

Merged

Conversation

jennifer-richards
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (287cf0f) 88.80% compared to head (a8fcbb3) 88.80%.
Report is 4 commits behind head on main.

❗ Current head a8fcbb3 differs from pull request most recent head 8719243. Consider uploading reports for the commit 8719243 to get more accurate results

Files Patch % Lines
ietf/doc/views_search.py 37.50% 5 Missing ⚠️
ietf/utils/markup_txt.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6916   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         284      285    +1     
  Lines       40361    40379   +18     
=======================================
+ Hits        35843    35860   +17     
- Misses       4518     4519    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 47dad07 into ietf-tools:main Jan 16, 2024
7 checks passed
@jennifer-richards jennifer-richards deleted the no-cant-haz-module-level-query branch January 16, 2024 14:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants