fix: Never show AD col on drafts_for_ad.html #6914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a transient HTML validation failure caused by assuming
ad.name != doc.ad.plain_name()
indicated thatad != doc.ad
.That check was, as far as I can tell, unnecessary because the search results were selected using
doc.ad == ad
. The check is removed here.I'm leaving in the initial change from including
ad_name
toad
in the template context because I don't see a benefit to handing around the string instead of the full record.For the record, the transient failure was: