-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Import IESG artifacts into the datatracker #6908
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6908 +/- ##
==========================================
- Coverage 88.98% 88.97% -0.02%
==========================================
Files 291 291
Lines 40717 40766 +49
==========================================
+ Hits 36233 36270 +37
- Misses 4484 4496 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only partially reviewed, but I think the tz handling is fragile and should probably be fixed. I expect that the dev machines will show incorrect times on migrated data. (If not, then I must be mistaken in my comments.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments - I think the tz stuff is still in need of changes.
The n+1 business looks good to me, but I'm still thinking about how it can be made more maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns are addressed.
I'm a little uneasy about the monkey patched optimizations - it'd be nice to find a better pattern for that. I don't see a reason to hold this up for solving that, though.
No description provided.