fix: better archive search links for group documents #6835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6835 +/- ##
==========================================
+ Coverage 88.78% 88.80% +0.01%
==========================================
Files 285 285
Lines 40324 40369 +45
==========================================
+ Hits 35800 35848 +48
+ Misses 4524 4521 -3 ☔ View full report in Codecov by Sentry. |
kesara
reviewed
Dec 27, 2023
| @@ -431,7 +431,7 @@ | |||
| {% endfor %} | |||
| {% if doc.group and doc.group.list_archive %} | |||
| {% if doc.group.list_archive|startswith:settings.MAILING_LIST_ARCHIVE_URL %} | |||
| <a href="{{ doc.group.list_archive }}?q={{ doc.name }}"> | |||
| <a href="{{ doc.group.list_archive }}?q={{ doc.name }}{% if doc.came_from_draft %} OR %22{{ doc.came_from_draft.name }}%22{% endif%}"> | |||
There was a problem hiding this comment.
Why not URL encode spaces around OR as well?
There was a problem hiding this comment.
Can you find an ecosystem where it's actually necessary? (escaping the double-quotes was mostly a quick way to construct a string that django wouldn't mangle on the way out).
There was a problem hiding this comment.
I requested a change just to avoid confusion. It's not apparent that spaces around OR are important.
kesara
approved these changes
Jan 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6823