fix: don't create a volunteer object when a person has already volunt… #6809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ietf/api/views.py
Outdated
| @@ -209,7 +209,7 @@ def err(code, text): | |||
| nomcom = NomCom.objects.get(is_accepting_volunteers=True) | |||
| except (NomCom.DoesNotExist, NomCom.MultipleObjectsReturned): | |||
| nomcom = None | |||
| if nomcom: | |||
| if nomcom and not Volunteer.objects.filter(nomcom=nomcom,person=object.person).exists(): | |||
There was a problem hiding this comment.
Volunteer.objects.get_or_create() instead?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6809 +/- ##
=======================================
Coverage 88.78% 88.79%
=======================================
Files 285 285
Lines 40324 40324
=======================================
+ Hits 35802 35804 +2
+ Misses 4522 4520 -2 ☔ View full report in Codecov by Sentry. |
jennifer-richards
previously approved these changes
Dec 18, 2023
jennifer-richards
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.