Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert custom form template to bootstrap #6763

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

pselkirk
Copy link
Collaborator

Fixes #6411

@pselkirk
Copy link
Collaborator Author

This creates a small change in the UI - extra fields, slight reordering.

Before:
Screen Shot 2023-12-11 at 12 43 21 PM

After:
Screen Shot 2023-12-11 at 12 41 28 PM

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce918c4) 88.80% compared to head (fd438a3) 88.81%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6763   +/-   ##
=======================================
  Coverage   88.80%   88.81%           
=======================================
  Files         285      285           
  Lines       40277    40285    +8     
=======================================
+ Hits        35769    35778    +9     
+ Misses       4508     4507    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

What the form shows can be controlled now by https://github.com/ietf-tools/datatracker/pull/6763/files#diff-a2a76783d6a823963a5dfad1b48beba6e254c40a3d2d8f6a3944a50bfeb0fd81R364

@cindymorgan - do you care about the order? Do you want us to let bcc/reply-to show up, or suppress them as the current form does?

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjsparks rjsparks merged commit cfaf84f into ietf-tools:main Dec 14, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interim_send_announcement doesn't display form errors
3 participants