fix: restore ancestors and decendants on document graph #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
changed the title
jennifer-richards
approved these changes
Nov 16, 2023
| history[url] = { | ||
| "name": d.name, | ||
| "rev": d.name, | ||
| "published": e and e.time.isoformat(), |
There was a problem hiding this comment.
Did you check whether the consumer of this data can handle a null in the JSON here?
There was a problem hiding this comment.
I did not, but it would mean we have an RFC without a published event, which is an anomaly and the consequence would be that the graph doesn't display.
| 'url': url, | ||
| } | ||
| if d.history_set.filter(rev=e.newrevisiondocevent.rev).exists(): | ||
| history[url]['pages'] = d.history_set.filter(rev=e.newrevisiondocevent.rev).first().pages |
There was a problem hiding this comment.
Should there be an analogous lookup of pages for the RFC case?
There was a problem hiding this comment.
good question - I'm not sure where it's used. It isn't used for this particular graph.
There was a problem hiding this comment.
I don't see that we use it, though we do describe using this endpoint as part of the API so outsiders might be using it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.