-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace markup_txt with rfc2html #6632
chore: Replace markup_txt with rfc2html #6632
Conversation
This is a pretty major change, not just a library substitution for similar effect. It essentially pulls a differently stylized htmlized view onto the main document page, replacing the plaintext view, getting use to even more confusion about where people should look. We need to push for less, and that's a bigger conversation than what we should have in a PR. |
So I would be all in favor of completely removing the preview from this template, and force people to click the button for the rendering they want. |
Should I remove the preview? |
I think we should have this discussion with the community (and really, this should be fodder for a more comprehensive UX-expert driven rework of the document display pages). Perhaps we should bring this up on tuesday's tools call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the 12Dec tools call discussion, we should try to push this forward, but it's failing several tests.
It's now down to template validation failures - rfc2html may need tweaking? |
I have some validation ignores queued up for next week. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6632 +/- ##
==========================================
+ Coverage 88.80% 88.81% +0.01%
==========================================
Files 285 284 -1
Lines 40374 40361 -13
==========================================
- Hits 35853 35846 -7
+ Misses 4521 4515 -6 ☔ View full report in Codecov by Sentry. |
drafts for ads is still failing validation |
Hm. It passed after rebasing. |
@larseggert - the cross-reference URLs generated by this were broken. At This will be reverted by #6909. Because we squash-merged this, you should be able to rebase this branch onto main after the revert PR is merged. |
I rebased the merged branch here: https://github.com/jennifer-richards/datatracker/tree/chore-remove-markup-txt-light (You probably should double-check that I did that correctly as there were a few conflicts. Note that it does not include commits that did not leave any changes, so the commit count doesn't match this PR's 14 commits.) |
This is a subset of #6629 that leaves the reStructured text stuff alone.