Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Capture volunteers from the registration system #6605

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

rpcross
Copy link
Collaborator

@rpcross rpcross commented Nov 5, 2023

No description provided.

@rpcross rpcross changed the base branch from main to feat/rfc November 5, 2023 09:38
now = datetime.datetime.now()
month = now.month
year = now.year
if month > 7:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining this if statement would be helpful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

Comment on lines 209 to 210
# registrants for the fall meeting will be volunteering for the
# following year's nomcom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true for the summer meeting too (the nomcom selection process is run by then usually).

Instead I think we should discuss when the registration system should offer volunteering for nomcom - it may only want to do so only for the spring meeting. Or only if there is a nomcom configured that is accepting volunteers (and we can make the assumption that there would never be two nomcoms accepting volunteers at the same time.).

rjsparks
rjsparks previously approved these changes Nov 22, 2023
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline - I want to confirm that it's ok to have bogus timestamps on existing Volunteer records and that the "time" field changing if the record is updated is what the field is meant to represent.

ietf/nomcom/models.py Outdated Show resolved Hide resolved
@jennifer-richards
Copy link
Member

Tests failing - migrations need an update

@rjsparks rjsparks changed the base branch from feat/rfc to main December 11, 2023 22:07
@rjsparks rjsparks dismissed stale reviews from jennifer-richards and themself December 11, 2023 22:07

The base branch was changed.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e211dc5) 88.80% compared to head (0f28936) 88.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6605   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         285      285           
  Lines       40280    40291   +11     
=======================================
+ Hits        35771    35782   +11     
  Misses       4509     4509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit e9d44d4 into ietf-tools:main Dec 14, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants