-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: meeting important dates can have markdown links #6594
Conversation
string = bleach_cleaner.clean( | ||
python_markdown.markdown( | ||
string, | ||
extensions=[ | ||
"extra", | ||
"nl2br", | ||
"sane_lists", | ||
"toc", | ||
], | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use/call the code in ietf/utils/markdown.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of a loop between the import statement (and no clue how to break this loop)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the same vein, I am unsure whether "toc" & "nl2br" extensions are useful or dangerous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit that moves the new filter to avoid the circular import (and simplifies it to use utils.markdown). Tests don't pass, but it's not this PRs fault. |
thanks, nicer indeed |
See the failed test run - the changes are producing html that doesn't validate. For example
|
This was happening because the |
Indeed ! Thanks |
To address feat #3911
Added a filter for the Django templates: 'markdown'
Data migration includes changing the important dates description to include the right markdown links.
Still to do (another issue to be created?) as some links in important dates include the actual meeting number :-(