Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Install fonts from xml2rfc-fonts #6300

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

kesara
Copy link
Member

@kesara kesara commented Sep 13, 2023

Fixes #6294

@kesara kesara marked this pull request as ready for review July 20, 2024 19:54
@rjsparks
Copy link
Member

rjsparks commented Sep 4, 2024

@kesara @jennifer-richards : checking as seems to have fallen into the meeting cracks - is this still the right thing to do, or did it get superseded with changing the dependency to xml2rfc[pdf]>=3.23.0?

@kesara
Copy link
Member Author

kesara commented Sep 4, 2024

@kesara @jennifer-richards : checking as seems to have fallen into the meeting cracks - is this still the right thing to do, or did it get superseded with changing the dependency to xml2rfc[pdf]>=3.23.0?

This PR is still valid. xml2rfc[pdf] extra does not install fonts.

@jennifer-richards
Copy link
Member

This updates the dockerfile used to create the app container in a dev environment, but won't affect the containers we deploy to production. That's set up in dev/build. I think the intention is to get these fonts to production?

@kesara
Copy link
Member Author

kesara commented Sep 5, 2024

This updates the dockerfile used to create the app container in a dev environment, but won't affect the containers we deploy to production. That's set up in dev/build. I think the intention is to get these fonts to production?

So the correct Dockerfile to use is docker/base.Dockerfile?

@jennifer-richards
Copy link
Member

So the correct Dockerfile to use is docker/base.Dockerfile?

Yes, everything is built on top of that I believe.

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes before merging to touch the files that would affect production

@kesara
Copy link
Member Author

kesara commented Sep 12, 2024

I have made requested changes with 09bb24e

@rjsparks rjsparks merged commit a345673 into ietf-tools:main Oct 1, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install fonts from xml2rfc-fonts repository
4 participants