fix: Move submission files using shutil.move() #6217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is correct. |
rjsparks
approved these changes
Aug 25, 2023
|
Quirk of current deployment to keep in mind: The archive is built from collections using ghostlinkd, which runs over a set of collections of drafts, one of which is the repository. Ghostlinkd necessarily works on a single filesystem (it watches the filesystem and makes hard links to construct the archive. (See https://github.com/ietf-tools/ghostlinkd) This will change when we move off of a shared filesystem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6216
The change to
rename_submission_files()is not strictly required because both source and dest are in the same directory so cannot be on different filesystems. However,shutil.move()usesos.rename()in this case so I think it's better to use it consistently.Also switches some
os.path.jointopathlib.Path- this works for Python 3.9 and later, which I believe is all we're supporting now, but calling it out in case I'm confused.