Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove DocAlias #6153

Merged
merged 25 commits into from
Aug 30, 2023
Merged

Conversation

rjsparks
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #6153 (cbfb5e8) into feat/rfc (114a3c5) will increase coverage by 0.04%.
The diff coverage is 87.23%.

@@             Coverage Diff              @@
##           feat/rfc    #6153      +/-   ##
============================================
+ Coverage     88.53%   88.57%   +0.04%     
============================================
  Files           290      290              
  Lines         40292    40157     -135     
============================================
- Hits          35672    35569     -103     
+ Misses         4620     4588      -32     
Files Changed Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/secr/utils/document.py 0.00% <ø> (-40.00%) ⬇️
ietf/stats/models.py 83.33% <ø> (ø)
ietf/submit/models.py 93.96% <ø> (ø)
ietf/doc/utils.py 87.54% <45.45%> (+0.22%) ⬆️
ietf/secr/telechat/views.py 79.91% <50.00%> (ø)
ietf/ipr/utils.py 58.33% <52.38%> (+3.94%) ⬆️
ietf/meeting/utils.py 88.42% <60.00%> (-0.07%) ⬇️
ietf/group/views.py 90.46% <66.66%> (+0.21%) ⬆️
ietf/doc/models.py 88.60% <72.72%> (+0.90%) ⬆️
... and 37 more

... and 1 file with indirect coverage changes

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to address / discuss, but looks like it's in good shape. Most of the bugs I came across are not new with this work, but we should fix them while we're touching the code.

ietf/group/views.py Show resolved Hide resolved
ietf/submit/views.py Show resolved Hide resolved
ietf/submit/views.py Show resolved Hide resolved
ietf/doc/models.py Show resolved Hide resolved
ietf/stats/views.py Show resolved Hide resolved
ietf/ipr/utils.py Outdated Show resolved Hide resolved
ietf/sync/tests.py Show resolved Hide resolved
ietf/doc/models.py Show resolved Hide resolved
@jennifer-richards jennifer-richards merged commit c085f0f into ietf-tools:feat/rfc Aug 30, 2023
8 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
@rjsparks rjsparks deleted the nomoredocalias branch October 2, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants