Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the IAB to the group menu #6130

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Aug 11, 2023

Fixes #6120

This is a kludge, but the IAB is unique in the set of groups we might want to navigate to. We could consider doing something similar for the IESG, especially after moving IESG statements and appeals to that page.
image

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #6130 (8a38991) into main (0faac4a) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6130   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files         290      290           
  Lines       40247    40249    +2     
=======================================
+ Hits        35688    35691    +3     
+ Misses       4559     4558    -1     
Files Changed Coverage Δ
ietf/group/views.py 90.26% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eww, but well motivated.

@rjsparks rjsparks merged commit bb6360f into ietf-tools:main Aug 11, 2023
8 checks passed
@rjsparks rjsparks deleted the iabmenuitem branch August 11, 2023 16:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to navigate to the IAB group itself via the menus
2 participants