Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Download questionnaire responses #6111

Merged
merged 2 commits into from
Aug 14, 2023
Merged

feat: Download questionnaire responses #6111

merged 2 commits into from
Aug 14, 2023

Conversation

pselkirk
Copy link
Collaborator

@pselkirk pselkirk commented Aug 9, 2023

Fixes #4981

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #6111 (e6d8f41) into main (82d91d3) will increase coverage by 0.01%.
Report is 39 commits behind head on main.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main    #6111      +/-   ##
==========================================
+ Coverage   88.66%   88.68%   +0.01%     
==========================================
  Files         290      290              
  Lines       40235    40264      +29     
==========================================
+ Hits        35676    35708      +32     
+ Misses       4559     4556       -3
Files Changed Coverage Δ
ietf/nomcom/views.py 92.65% <78.94%> (+0.07%) ⬆️

... and 7 files with indirect coverage changes

rjsparks
rjsparks requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits to address please

ietf/nomcom/views.py Outdated Show resolved Hide resolved
ietf/templates/nomcom/download_questio.txt Outdated Show resolved Hide resolved
ietf/templates/nomcom/download_questio.txt Outdated Show resolved Hide resolved
@rjsparks rjsparks merged commit 73c2a6a into ietf-tools:main Aug 14, 2023
8 checks passed
@pselkirk pselkirk deleted the fix-4981 branch August 15, 2023 18:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjsparks rjsparks rjsparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download questionnaire responses
2 participants
@pselkirk @rjsparks