Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "generate email" to action on nominees page (#4893) #5959

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

pselkirk
Copy link
Collaborator

@pselkirk pselkirk commented Jul 13, 2023

Fixes #4893

Django doesn't allow HttpResponseRedirect to a mailto URL, so this adds a button [Mail to selected nominees] at the bottom of the page, with the mailto href.

ietf/nomcom/views.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #5959 (f9fa298) into main (3fe1fcf) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #5959      +/-   ##
==========================================
- Coverage   88.64%   88.62%   -0.02%     
==========================================
  Files         288      288              
  Lines       40003    40006       +3     
==========================================
- Hits        35459    35455       -4     
- Misses       4544     4551       +7     
Impacted Files Coverage Δ
ietf/nomcom/views.py 92.90% <33.33%> (-0.22%) ⬇️

... and 3 files with indirect coverage changes

@rjsparks rjsparks merged commit 0693a43 into ietf-tools:main Jul 17, 2023
8 checks passed
@pselkirk pselkirk deleted the fix-4893 branch July 18, 2023 01:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "generate email" to action on nominees page
2 participants