Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send the whole txt submission to the DraftParser #5956

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

rjsparks
Copy link
Member

No description provided.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this helps #5731?

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #5956 (9ee07dd) into main (09f3477) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
- Coverage   88.67%   88.63%   -0.04%     
==========================================
  Files         288      288              
  Lines       40001    40003       +2     
==========================================
- Hits        35471    35458      -13     
- Misses       4530     4545      +15     
Impacted Files Coverage Δ
ietf/doc/utils.py 87.15% <100.00%> (+0.01%) ⬆️
ietf/submit/forms.py 79.02% <100.00%> (+0.03%) ⬆️

... and 4 files with indirect coverage changes

@rjsparks rjsparks merged commit 3fe1fcf into ietf-tools:main Jul 12, 2023
@rjsparks
Copy link
Member Author

Any chance this helps #5731?

No - that still fails:

main-celery-1   | django.db.utils.IntegrityError: null value in column "title" of relation "submit_submission" violates not-null constraint

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
@rjsparks rjsparks deleted the all_the_text branch August 11, 2023 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants