fix: various fixes in ietf.doc #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-richards
approved these changes
Jul 7, 2023
| @@ -2705,24 +2705,27 @@ def should_404(self, argdict): | |||
| r = self.client.get(url) | |||
| self.assertEqual(r.status_code, 404) | |||
|
|
|||
| # This takes a _long_ time (32s on a 2022 m1 macbook pro) - is it worth what it covers? | |||
There was a problem hiding this comment.
Seems like a lot of permutations being checked, maybe cut it down to just the pdf extension? Another option would be to mock out the pdf generation and just check that it calls the expected method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.