fix: Show rfc documents via document_main view #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
reviewed
Jul 5, 2023
| @@ -494,7 +594,7 @@ def document_main(request, name, rev=None, document_html=False): | |||
|
|
|||
| augment_docs_and_user_with_user_info([doc], request.user) | |||
|
|
|||
| published = doc.latest_event(type="published_rfc") | |||
| published = doc.latest_event(type="published_rfc") # todo rethink this now that published_rfc is on rfc | |||
There was a problem hiding this comment.
Correct - this should always be None for a document of type draft. If we want the draft view to say anything about when the rfc it became was published we should be looking through the relationship.
rjsparks
reviewed
Jul 5, 2023
| @@ -11,15 +11,15 @@ | |||
| <th scope="row">{% if document_html %}Document type{% else %}Type{% endif %}</th> | |||
| <td class="edit"></td> | |||
| <td> | |||
| {% if doc.get_state_slug == "rfc" and not snapshot %} | |||
| {% if doc.is_rfc %} | |||
There was a problem hiding this comment.
In the long run, I think we can remove is_rfc() in favor of looking at type.
There was a problem hiding this comment.
Ok - I'd started on this road and saw you were going the type route. Decided to stick with this for this PR rather than mixing things up. I'll add switching these to the todo list.
rjsparks
reviewed
Jul 5, 2023
rjsparks
approved these changes
Jul 5, 2023
|
This looks to be on the right track to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores basic displaying of RFC documents, adding a separate path in the view for the rfc document type. Makes a first pass at removing irrelevant information from the view.
Does not yet fix up the document timeline or rearrange the display of the document stream.