Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Be a little clearer when feedback is closed (or not yet open). #5861

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

pselkirk
Copy link
Collaborator

Fixes #3492

@pselkirk pselkirk marked this pull request as ready for review June 21, 2023 18:17
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #5861 (1fb9a8e) into main (62d6891) will increase coverage by 0.07%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main    #5861      +/-   ##
==========================================
+ Coverage   88.66%   88.73%   +0.07%     
==========================================
  Files         288      288              
  Lines       39949    39965      +16     
==========================================
+ Hits        35421    35464      +43     
+ Misses       4528     4501      -27     
Impacted Files Coverage Δ
ietf/doc/views_doc.py 91.61% <ø> (ø)
ietf/doc/utils_search.py 81.17% <50.00%> (+0.58%) ⬆️
ietf/api/__init__.py 69.69% <100.00%> (+0.62%) ⬆️
ietf/doc/feeds.py 99.24% <100.00%> (+23.61%) ⬆️
ietf/group/views.py 90.53% <100.00%> (+<0.01%) ⬆️
ietf/meeting/models.py 85.15% <100.00%> (ø)
ietf/nomcom/forms.py 95.39% <100.00%> (ø)

... and 5 files with indirect coverage changes

@rjsparks rjsparks merged commit 53b5e23 into ietf-tools:main Jun 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Once feedback is closed, the NomCom feedback page is confusing
2 participants