Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't resort a table if sort query argument is present #5825

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

larseggert
Copy link
Collaborator

Fixes #5686

@rjsparks rjsparks requested a review from NGPixel June 14, 2023 16:53
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #5825 (09b645f) into main (f5365b2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5825      +/-   ##
==========================================
- Coverage   88.66%   88.66%   -0.01%     
==========================================
  Files         288      288              
  Lines       39949    39950       +1     
==========================================
- Hits        35422    35421       -1     
- Misses       4527     4529       +2     
Impacted Files Coverage Δ
ietf/group/views.py 90.53% <100.00%> (+<0.01%) ⬆️

... and 4 files with indirect coverage changes

ietf/static/js/list.js Outdated Show resolved Hide resolved
@larseggert larseggert requested a review from NGPixel June 14, 2023 23:27
@rjsparks rjsparks merged commit 01e2d8b into ietf-tools:main Jun 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
@larseggert larseggert deleted the fix-5686 branch June 21, 2023 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document list undoes clicks on links in sorting headers
3 participants