refactor: Do not use canonical_name() for charters #5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily raise an exception for testing
Codecov Report
@@ Coverage Diff @@
## feat/rfc #5818 +/- ##
============================================
+ Coverage 88.65% 88.69% +0.03%
============================================
Files 288 288
Lines 39950 39922 -28
============================================
- Hits 35419 35407 -12
+ Misses 4531 4515 -16
|
rjsparks
approved these changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the special case for
chartertype documents fromcanonical_name(). Uses ofcanonical_name()are replaced withcharter.nameor the equivalent. Prevents creation of charterDocumentinstances with names not matching the expected format.