Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render charters on about page using markdown #5795

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Jun 9, 2023

Remember the /group/<acronym>/about/rendertest view for a before/after comparison. (This PR fixes a js issue in that view).

The last time we pressed people to look at rendertest, I don't think we were using nl2br, so some of the really old charters with strange linebreaks in their text files will still just look strange, but overall, using it will likely produce the least surprise.

cc: @larseggert

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #5795 (c3da308) into main (6737095) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5795      +/-   ##
==========================================
- Coverage   88.67%   88.67%   -0.01%     
==========================================
  Files         288      288              
  Lines       39936    39937       +1     
==========================================
  Hits        35413    35413              
- Misses       4523     4524       +1     
Impacted Files Coverage Δ
ietf/group/views.py 90.96% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

@jennifer-richards jennifer-richards changed the title feat: render charters on about page uring markdown feat: render charters on about page using markdown Jun 11, 2023
@rjsparks rjsparks marked this pull request as draft June 13, 2023 15:56
@rjsparks
Copy link
Member Author

@larseggert wants to see if he can tweak this for minor improvements before it is merged.

@larseggert
Copy link
Collaborator

I don't think there is anything more I can easily do. Fixing the oddities would entail switching libs and/or writing custom plugins.

@rjsparks rjsparks marked this pull request as ready for review June 13, 2023 17:22
@rjsparks rjsparks merged commit a3db61c into ietf-tools:main Jun 13, 2023
@rjsparks
Copy link
Member Author

Mutter: foot-gunned by the GH stateful type-of-merge button once again...

@rjsparks rjsparks deleted the markdowncharters branch June 13, 2023 17:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants