Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ignore acceptable order change #5727

Merged
merged 2 commits into from
May 31, 2023
Merged

test: ignore acceptable order change #5727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
046c3d3
test: ignore acceptable order change
rjsparks May 31, 2023
b017d49
fix: address review comments
rjsparks May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ietf/secr/sreq/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def test_edit(self):
list(TimerangeName.objects.filter(name__in=['thursday-afternoon-early', 'thursday-afternoon-late']).values('name'))
)
self.assertFalse(sessions[0].joint_with_groups.count())
self.assertEqual(list(sessions[1].joint_with_groups.all()), [group3, group4])
self.assertEqual(set(list(sessions[1].joint_with_groups.all())), set([group3, group4]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the set() need the list() first? I'd have thought it can work straight from the QuerySet.

Could also use a set literal {group3, group4}

Up to you whether you care enough about this to change.


# Check whether the updated data is visible on the view page
r = self.client.get(redirect_url)
Expand Down