Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use QuerySetAny alias for QuerySet type checks #5722

Conversation

jennifer-richards
Copy link
Member

Fixes failing test in #5700

QuerySetAny is an alias for QuerySet that works some magic to satisfy the type checker. Other than during type checking, it's the same as QuerySet.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #5722 (8cd09ab) into feat/django4 (4012a21) will decrease coverage by 0.02%.
The diff coverage is 88.00%.

@@               Coverage Diff                @@
##           feat/django4    #5722      +/-   ##
================================================
- Coverage         88.74%   88.72%   -0.02%     
================================================
  Files               287      287              
  Lines             39876    39889      +13     
================================================
+ Hits              35387    35392       +5     
- Misses             4489     4497       +8     
Impacted Files Coverage Δ
ietf/meeting/forms.py 97.03% <ø> (ø)
ietf/doc/utils.py 87.13% <62.50%> (-0.17%) ⬇️
ietf/doc/feeds.py 75.63% <100.00%> (ø)
ietf/doc/models.py 88.87% <100.00%> (+0.03%) ⬆️
ietf/meeting/models.py 86.35% <100.00%> (+0.04%) ⬆️
ietf/nomcom/utils.py 91.30% <100.00%> (ø)
ietf/submit/utils.py 90.15% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

@jennifer-richards jennifer-richards merged commit 3cf5550 into ietf-tools:feat/django4 May 31, 2023
@jennifer-richards jennifer-richards deleted the queryset-type-check branch May 31, 2023 18:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants