Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use variable for static.ietf.org references #5692

Merged
merged 1 commit into from
May 25, 2023

Conversation

NGPixel
Copy link
Member

@NGPixel NGPixel commented May 25, 2023

Closes #5687

@NGPixel NGPixel requested a review from rjsparks May 25, 2023 20:39
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #5692 (33b05b7) into main (6178519) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5692      +/-   ##
==========================================
- Coverage   88.74%   88.74%   -0.01%     
==========================================
  Files         285      285              
  Lines       39845    39851       +6     
==========================================
+ Hits        35362    35367       +5     
- Misses       4483     4484       +1     
Impacted Files Coverage Δ
ietf/meeting/forms.py 97.03% <ø> (ø)
ietf/doc/models.py 88.87% <100.00%> (+0.03%) ⬆️
ietf/meeting/models.py 86.35% <100.00%> (+0.04%) ⬆️
ietf/nomcom/utils.py 91.30% <100.00%> (ø)

... and 4 files with indirect coverage changes

@rjsparks rjsparks merged commit 0a11892 into ietf-tools:main May 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev mode loads assets from static.ietf.org
2 participants