-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Django 3.2 #5629
Merged
jennifer-richards
merged 25 commits into
ietf-tools:feat/django4
from
jennifer-richards:django32
May 16, 2023
Merged
chore: Upgrade to Django 3.2 #5629
jennifer-richards
merged 25 commits into
ietf-tools:feat/django4
from
jennifer-richards:django32
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy complains if QuerySet is used because it uses a parameterized generic type.
Codecov Report
@@ Coverage Diff @@
## feat/django4 #5629 +/- ##
================================================
- Coverage 88.73% 88.73% -0.01%
================================================
Files 285 287 +2
Lines 39812 39841 +29
================================================
+ Hits 35328 35353 +25
- Misses 4484 4488 +4
|
rjsparks
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes of note:
django-password-strength
. The BSD-licensed code for the widgets are moved toietfauth.widgets
. We were already using a copy of the JS code in ourpassword_strength.js
requirements.txt
now includes a bunch oftypes-*
python packages for mypy tests - I haven't looked into installing these only for testing