Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Truncate text agenda labels to not overflow colums #5276

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

larseggert
Copy link
Collaborator

Also tweak the spacing some and add a guard for an undefined field.

Fixes #1313

Also tweak the spacing some and add a guard for an undefined field.

Fixes ietf-tools#1313
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #5276 (7692b57) into main (0ec1264) will decrease coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #5276      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.01%     
==========================================
  Files         295      294       -1     
  Lines       40114    40071      -43     
==========================================
- Hits        35534    35494      -40     
+ Misses       4580     4577       -3     
Impacted Files Coverage Δ
ietf/iesg/urls.py 100.00% <ø> (ø)
ietf/meeting/models.py 86.03% <ø> (-0.05%) ⬇️
ietf/meeting/urls.py 81.25% <ø> (ø)
ietf/iesg/views.py 92.53% <85.18%> (-0.71%) ⬇️
ietf/doc/mails.py 96.20% <100.00%> (ø)
ietf/doc/utils_search.py 80.58% <100.00%> (ø)
ietf/group/views.py 90.95% <100.00%> (+0.09%) ⬆️
ietf/ietfauth/views.py 92.12% <100.00%> (+1.09%) ⬆️
ietf/meeting/helpers.py 89.84% <100.00%> (-0.07%) ⬇️
ietf/meeting/views.py 91.12% <100.00%> (-0.01%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 6f8cba5 into ietf-tools:main Mar 3, 2023
@larseggert larseggert deleted the fix-1313 branch March 3, 2023 15:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text agenda has column overruns because of long room names
2 participants