Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Let csv.writer handle encoding for agenda_csv view #5225

Merged

Conversation

jennifer-richards
Copy link
Member

Fixes #5224

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #5225 (8987f0a) into main (0ec1264) will decrease coverage by 0.03%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##             main    #5225      +/-   ##
==========================================
- Coverage   88.58%   88.56%   -0.03%     
==========================================
  Files         295      294       -1     
  Lines       40114    40088      -26     
==========================================
- Hits        35534    35502      -32     
- Misses       4580     4586       +6     
Impacted Files Coverage Δ
ietf/iesg/urls.py 100.00% <ø> (ø)
ietf/meeting/urls.py 81.25% <ø> (ø)
ietf/iesg/views.py 92.53% <85.18%> (-0.71%) ⬇️
ietf/doc/mails.py 96.20% <100.00%> (ø)
ietf/group/views.py 90.95% <100.00%> (+0.09%) ⬆️
ietf/meeting/helpers.py 89.84% <100.00%> (-0.07%) ⬇️
ietf/meeting/views.py 91.13% <100.00%> (+<0.01%) ⬆️
ietf/secr/proceedings/proc_utils.py 86.33% <100.00%> (ø)
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️
ietf/doc/views_search.py 88.63% <0.00%> (-0.62%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 1eb16c9 into ietf-tools:main Feb 28, 2023
@jennifer-richards jennifer-richards deleted the jennifer/agenda-csv-encoding branch February 28, 2023 18:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agenda.csv is badly formatted
2 participants