Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Prefill the abstract, shepherd and AD info into a ballot writeup #5218

Merged
merged 6 commits into from
Feb 27, 2023
Merged

feat: Prefill the abstract, shepherd and AD info into a ballot writeup #5218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b63fa2b
feat: Prefill the abstract, shepherd and AD info into a ballot writeup
larseggert Feb 27, 2023
79c5806
Suggestions from @rjsparks
larseggert Feb 27, 2023
db50929
Remove instructions to add IANA Expert template.
larseggert Feb 27, 2023
446200f
Merge branch 'main' into feat-prefill-ballot-writeup
larseggert Feb 27, 2023
25df9cd
Merge branch 'feat-prefill-ballot-writeup' of github.com:larseggert/d…
larseggert Feb 27, 2023
e1b7231
Make "notes" fields for various bodies conditioned on the doc stream
larseggert Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ietf/doc/mails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def generate_ballot_writeup(request, doc):
e.doc = doc
e.rev = doc.rev
e.desc = "Ballot writeup was generated"
e.text = force_text(render_to_string("doc/mail/ballot_writeup.txt", {'iana': iana}))
e.text = force_text(render_to_string("doc/mail/ballot_writeup.txt", {'iana': iana, 'doc': doc, 'abstract': doc.abstract.rstrip()}))

# caller is responsible for saving, if necessary
return e
Expand Down
20 changes: 11 additions & 9 deletions ietf/templates/doc/mail/ballot_writeup.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{% autoescape off %}
Technical Summary

{% load ietf_filters %}{% autoescape off %}Technical Summary
{% if doc.abstract %}
{{ abstract }}
larseggert marked this conversation as resolved.
Show resolved Hide resolved
{% else %}
Relevant content can frequently be found in the abstract
and/or introduction of the document. If not, this may be
an indication that there are deficiencies in the abstract
or introduction.

{% endif %}
Working Group Summary

Was there anything in the WG process that is worth noting?
Expand All @@ -26,12 +27,14 @@ Document Quality
Review, on what date was the request posted?

Personnel

{% if doc.shepherd and doc.ad %}{% filter wordwrap:"76" %}
The Document Shepherd for this document is {{ doc.shepherd.person.name }}. The Responsible Area Director is {{ doc.ad.name }}.{% endfilter %}
{% else %}
larseggert marked this conversation as resolved.
Show resolved Hide resolved
Who is the Document Shepherd for this document? Who is the
Responsible Area Director? If the document requires IANA
experts(s), insert 'The IANA Expert(s) for the registries
in this document are <TO BE ADDED BY THE AD>.'

{% endif %}
IRTF Note

(Insert IRTF Note here or remove section)
Expand All @@ -42,7 +45,6 @@ IESG Note

IANA Note
{% if iana %}
{% load ietf_filters %}{% filter wordwrap:"76"|indent:2 %}{{ iana }}{% endfilter %}
{% filter wordwrap:"76"|indent:2 %}{{ iana }}{% endfilter %}
{% endif %}
(Insert IANA Note here or remove section)
{% endautoescape%}
(Insert IANA Note here or remove section){% endautoescape%}