-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: point menu item for editoral stream to rswg documents #5206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not certain, but I think there's an unused factory call - suggest dropping that or, better, testing that the forwarding actually hits a valid view.
@@ -41,6 +41,11 @@ def test_stream_documents(self): | |||
self.assertEqual(r.status_code, 200) | |||
self.assertContains(r, draft.name) | |||
|
|||
EditorialDraftFactory() # Quick way to ensure RSWG exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? Since you have fetch_redirect_response=False
, I don't think you'll actually hit the view that checks whether the group exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was fighting against the internals of assertRedirects
since I was redirecting to something that redirected. While that might have been better (since the redirect was to the dispatcher for group), I short-circuited to what the current place the dispatcher for group sends rswg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - if you think it was better as it was I don't object to that, just want to be sure that we test that the redirects will eventually land.
Codecov Report
@@ Coverage Diff @@
## main #5206 +/- ##
==========================================
+ Coverage 88.54% 88.58% +0.03%
==========================================
Files 295 295
Lines 40110 40116 +6
==========================================
+ Hits 35516 35535 +19
+ Misses 4594 4581 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fixes #5203