Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Guard against null form-group around name fields in session_details_form.js #5175

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes #5174

This JS file supports the ietf.meeting.forms.SessionDetailsForm form. In normal use, the form is rendered with its inputs (including name and short) inside div.form-group elements. However, the form is also reused in the secr.sreq app, where the fields are rendered ad hoc. The short field was recently added as an always-hidden field not contained inside a div.form-group, causing the JS code to fail. As a result, the visibility of various fields was not updated, including the purpose/type fields complained about in #5174.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #5175 (359f6cc) into main (f9c2376) will decrease coverage by 0.01%.
The diff coverage is 90.27%.

@@            Coverage Diff             @@
##             main    #5175      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         295      295              
  Lines       40046    40050       +4     
==========================================
+ Hits        35458    35460       +2     
- Misses       4588     4590       +2     
Impacted Files Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/doc/views_doc.py 91.53% <ø> (+0.15%) ⬆️
ietf/api/views.py 89.44% <89.55%> (-0.03%) ⬇️
ietf/api/urls.py 100.00% <100.00%> (ø)
ietf/sync/discrepancies.py 100.00% <100.00%> (ø)
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️
ietf/nomcom/utils.py 91.54% <0.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 6a3694e into ietf-tools:main Feb 21, 2023
@jennifer-richards jennifer-richards deleted the jennifer/sreq-purpose branch February 21, 2023 17:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inappropriate options offered when requesting more than one session through secr/sreq
2 participants