Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache page content, not page menus #5170

Merged
merged 2 commits into from
Feb 21, 2023
Merged

fix: cache page content, not page menus #5170

merged 2 commits into from
Feb 21, 2023

Conversation

rjsparks
Copy link
Member

No description provided.

jennifer-richards
jennifer-richards requested changes Feb 17, 2023
View reviewed changes
Copy link
Member

@jennifer-richards jennifer-richards left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to close your {% cache... %} tags (though maybe they work without that??)

Edit: no, the tests failed b/c of that, so they're needed.

ietf/templates/meeting/past.html
{% block pagehead %}
<link rel="stylesheet" href="{% static "ietf/css/list.css" %}">
{% endblock %}
{% block title %}Past Meetings{% endblock %}
{% block content %}
{% cache 3600 pastmeetings %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs {% endcache %}

ietf/templates/meeting/proceedings_progress_report.html
{% block title %}IETF {{ meeting.number }} Proceedings - Progress Report{% endblock %}
{% block content %}
{% cache 3600 proceedings_progress_report meeting.number %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs {% endcache %}

@rjsparks
Copy link
Member Author

D'oh

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #5170 (da4c5a0) into main (f9c2376) will increase coverage by 0.00%.
The diff coverage is 90.27%.

@@           Coverage Diff           @@
##             main    #5170   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         295      295           
  Lines       40046    40048    +2     
=======================================
+ Hits        35458    35460    +2     
  Misses       4588     4588
Impacted Files Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/doc/views_doc.py 91.53% <ø> (+0.15%) ⬆️
ietf/meeting/views.py 90.85% <ø> (-0.01%) ⬇️
ietf/api/views.py 89.44% <89.55%> (-0.03%) ⬇️
ietf/api/urls.py 100.00% <100.00%> (ø)
ietf/sync/discrepancies.py 100.00% <100.00%> (ø)
ietf/doc/views_search.py 89.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 0ce2b8e into ietf-tools:main Feb 21, 2023
@rjsparks rjsparks deleted the nocachethepages branch February 21, 2023 16:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jennifer-richards jennifer-richards jennifer-richards approved these changes

@rpcross rpcross Awaiting requested review from rpcross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjsparks @jennifer-richards