Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return to expected schedule after editing sessions/timeslots #5158

Merged

Conversation

jennifer-richards
Copy link
Member

Fixes #3591.

The "Edit rooms" button from the timeslot editor still leads off into the secr app. I did not update that to return cleanly - still have to use browser history or navigate back through the agenda list. When we replace the secr app for editing rooms we can clean this up.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #5158 (5982ab1) into main (e280b25) will increase coverage by 0.03%.
The diff coverage is 82.48%.

❗ Current head 5982ab1 differs from pull request most recent head 4832d79. Consider uploading reports for the commit 4832d79 to get more accurate results

@@            Coverage Diff             @@
##             main    #5158      +/-   ##
==========================================
+ Coverage   88.50%   88.53%   +0.03%     
==========================================
  Files         295      295              
  Lines       40015    40046      +31     
==========================================
+ Hits        35415    35456      +41     
+ Misses       4600     4590      -10     
Impacted Files Coverage Δ
ietf/doc/expire.py 95.31% <ø> (ø)
ietf/doc/views_ballot.py 92.86% <ø> (ø)
ietf/idindex/index.py 95.05% <ø> (ø)
ietf/ietfauth/utils.py 92.85% <ø> (ø)
ietf/ipr/utils.py 53.96% <0.00%> (ø)
ietf/review/models.py 91.91% <ø> (ø)
ietf/stats/views.py 93.10% <ø> (ø)
ietf/utils/draft.py 71.75% <0.00%> (ø)
ietf/doc/views_draft.py 91.94% <25.00%> (ø)
ietf/submit/forms.py 82.74% <37.50%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit f9c2376 into ietf-tools:main Feb 16, 2023
@jennifer-richards jennifer-richards deleted the jennifer/better-back-to-sched branch February 16, 2023 16:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically return to correct schedule in schedule editor
2 participants