fix: Move rfcdiff-latest-json API call from /doc to /api #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
reviewed
Feb 15, 2023
kesara
force-pushed
the
fix/move-rfcdiff-latest-json
branch
2 times, most recently
from
1b3574d
to
a58a253
Compare
Codecov Report
@@ Coverage Diff @@
## main #5155 +/- ##
==========================================
+ Coverage 88.50% 88.54% +0.03%
==========================================
Files 295 295
Lines 40015 40030 +15
==========================================
+ Hits 35415 35444 +29
+ Misses 4600 4586 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
requested changes
Feb 16, 2023
| @@ -56,6 +57,9 @@ | |||
| url(r'^version/?$', api_views.version), | |||
| # Application authentication API key | |||
| url(r'^appauth/[authortools|bibxml]', api_views.app_auth), | |||
| # latest versions | |||
| url(r'^rfcdiff-latest-json/%(name)s(?:-%(rev)s)?(\.txt|\.html)?/?$' % settings.URL_REGEXPS, api_views.rfcdiff_latest_json), | |||
There was a problem hiding this comment.
Sorry to ask for multiple changes, but it occurs to me that this would be better as a permanent redirect in case there are other users of the endpoint we're not yet aware of.
There was a problem hiding this comment.
No worries, I have updated the ietf/doc/urls.py URLs as permanent redirects.
Old /doc/rfcdiff-latest-json/ URL is changed to a permanent redirect to /api/doc/rfcdiff-latest-json/
kesara
force-pushed
the
fix/move-rfcdiff-latest-json
branch
from
a58a253
to
f114b00
Compare
rjsparks
approved these changes
Feb 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.