Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow agenda_note to be edited from the schedule editor #5115

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes #3613 by providing an easy alternative to embedding extended descriptions in the session name.

Includes a migration to put old sessions marked as 'CANCELED' into the 'canceled' state. There are two sessions that appear to have been canceled that are not migrated automatically. These should be cleaned up manually.

>>> pp(list(Session.objects.with_current_status().exclude(current_status='canceled').filter(agenda_note__icontains='canceled').order_by('meeting__date').values_list('meeting__number', 'pk', 'agenda_note')))
[('75', 1179, 'Friday session Canceled'),
 ('75', 11179, 'Friday session Canceled'),
 ('79', 1722, 'Monday 1510-1610 CANCELED ONLY'),
 ('79', 11722, 'Monday 1510-1610 CANCELED ONLY')]

(The second and third entries are the ones indicated as being canceled.)

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #5115 (90740b0) into main (bfe25fc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5115      +/-   ##
==========================================
+ Coverage   88.50%   88.51%   +0.01%     
==========================================
  Files         296      295       -1     
  Lines       40018    40015       -3     
==========================================
+ Hits        35416    35418       +2     
+ Misses       4602     4597       -5     
Impacted Files Coverage Δ
ietf/meeting/forms.py 97.02% <ø> (ø)
ietf/meeting/views.py 90.70% <100.00%> (+<0.01%) ⬆️
ietf/secr/proceedings/proc_utils.py 86.33% <100.00%> (-0.09%) ⬇️
ietf/secr/sreq/forms.py 98.31% <100.00%> (+0.03%) ⬆️
ietf/secr/sreq/views.py 91.16% <100.00%> (-0.40%) ⬇️
ietf/nomcom/utils.py 91.54% <0.00%> (-0.49%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.42%) ⬇️
ietf/group/utils.py 94.17% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennifer-richards jennifer-richards marked this pull request as ready for review February 9, 2023 15:44
@rjsparks rjsparks merged commit 1fc2042 into ietf-tools:main Feb 9, 2023
@jennifer-richards jennifer-richards deleted the jennifer/agenda-note branch February 10, 2023 15:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long session names lead to unwieldy agenda filter parameter keywords
2 participants