Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve remote_instructions and short name in secr.sreq.edit() #5113

Merged

Conversation

jennifer-richards
Copy link
Member

Fixes #3710

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #5113 (491b3a1) into main (bfe25fc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5113      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.01%     
==========================================
  Files         296      295       -1     
  Lines       40018    40016       -2     
==========================================
- Hits        35416    35412       -4     
- Misses       4602     4604       +2     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.70% <100.00%> (+<0.01%) ⬆️
ietf/secr/sreq/forms.py 98.31% <100.00%> (+0.03%) ⬆️
ietf/secr/sreq/views.py 91.16% <100.00%> (-0.40%) ⬇️
ietf/submit/checkers.py 73.60% <0.00%> (-3.05%) ⬇️
ietf/nomcom/utils.py 91.30% <0.00%> (-0.73%) ⬇️
ietf/doc/views_search.py 89.23% <0.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit dd7bed4 into ietf-tools:main Feb 8, 2023
@jennifer-richards jennifer-richards deleted the jennifer/remote-instructions branch February 9, 2023 16:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a session erases its Remote Instructions
2 participants