Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use session name instead of timeslot name on agenda #5086

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

jennifer-richards
Copy link
Member

@jennifer-richards jennifer-richards commented Feb 3, 2023

Fixes #4457.

This uses the session name instead of the timeslot name to label special (type != "regular") sessions on the meeting agenda. The timeslot name is used for regular session headings ("Session I", "Session II", etc). This allows the agenda to be updated using the "Edit session" links from the schedule editor.

Changes the rendered agendas for some existing meetings. Includes a data migration to replace Session.name with TimeSlot.name for all non-'regular' sessions of IETF meetings except meetings 91-98. The meetings in that range had more descriptive names on the Session instances. I have not exhaustively compared meeting agendas, but all the agendas I examined looked the same or better with these updates.

A list of the session names that changed on my dev instance:
session-names.csv
The old session names are labeled session.name in the file. The new names are labeled timeslot.name.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #5086 (06d59b4) into main (bfe25fc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 06d59b4 differs from pull request most recent head af8750a. Consider uploading reports for the commit af8750a to get more accurate results

@@            Coverage Diff             @@
##             main    #5086      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.01%     
==========================================
  Files         296      296              
  Lines       40018    40020       +2     
==========================================
+ Hits        35416    35417       +1     
- Misses       4602     4603       +1     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.70% <100.00%> (+<0.01%) ⬆️
ietf/nomcom/utils.py 91.54% <0.00%> (-0.49%) ⬇️
ietf/utils/mail.py 79.85% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennifer-richards jennifer-richards marked this pull request as ready for review February 7, 2023 20:35
@rjsparks rjsparks merged commit 6cfbab6 into ietf-tools:main Feb 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a clearer way to specify session/timeslot names on the agenda
2 participants