Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the format element from the bibxml-id source of truth #5017

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Jan 23, 2023

fixes #5018

@rjsparks
Copy link
Member Author

cc: @alicerusso, @ajeanmahoney, @cabo, @reschke

Note that this does not add a target attribute. We can discuss that in a separate issue.

@rjsparks rjsparks marked this pull request as ready for review January 23, 2023 16:38
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #5017 (3501961) into main (570bd14) will decrease coverage by 0.01%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main    #5017      +/-   ##
==========================================
- Coverage   88.47%   88.47%   -0.01%     
==========================================
  Files         296      296              
  Lines       39818    39851      +33     
==========================================
+ Hits        35230    35257      +27     
- Misses       4588     4594       +6     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.69% <98.00%> (+0.12%) ⬆️
ietf/meeting/templatetags/proceedings_filters.py 88.23% <0.00%> (-5.89%) ⬇️
ietf/meeting/models.py 85.91% <0.00%> (-0.59%) ⬇️
ietf/group/models.py 92.30% <0.00%> (-0.37%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️
ietf/nomcom/utils.py 91.54% <0.00%> (+0.24%) ⬆️
ietf/utils/text.py 86.58% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cabo
Copy link
Collaborator

cabo commented Jan 23, 2023

Note that this does not add a target attribute. We can discuss that in a separate issue.

This is pretty much what kramdown-rfc now does for RFCs and I-Ds in default mode (it also deletes any target attributes on RFCs and I-Ds, so you don't need to bother putting them in).
xml2rfc does a great job computing the URIs (this is not so REST, but works great).

@rjsparks rjsparks merged commit 43c7e92 into ietf-tools:main Jan 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
@rjsparks rjsparks deleted the noformat branch February 2, 2023 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the format element from the bibxml produced by the datatracker for bibxml-ids
3 participants