feat: Can we provide a better review assignment email subject. #3760 #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evyncke
changed the title
|
It looks like that I should also have updated the tests... |
Do you want me to do that, or will you have time soon? |
|
Happy to keep learning on the tests aspects in the coming weeks. |
larseggert
reviewed
Nov 21, 2022
|
Converting to draft while the above changes are in progress. Please mark it ready for review once they're in place. |
…s#5372) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…5371) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…er (ietf-tools#5370) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…etf-tools#5369) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## feat/postgres #4769 +/- ##
=================================================
+ Coverage 88.80% 88.81% +0.01%
=================================================
Files 285 285
Lines 39525 39525
=================================================
+ Hits 35101 35105 +4
+ Misses 4424 4420 -4
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
To clean up the PR (messed up by wrong merge), I have created a new one #5415 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About #3760
1/ email subject now contains the reviewer name + deadline
2/ copies is also sent to the review requester and also to all secretaries
As discussed in #3760 with @cjbc @Abhayakara @kivinen @jgscudder