feat: allow secretariat to edit/cancel sreqs when the tool is locked #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
requested changes
Oct 28, 2022
ietf/secr/sreq/views.py
Outdated
| @@ -850,6 +850,8 @@ def view(request, acronym, num = None): | |||
|
|
|||
| return render(request, 'sreq/view.html', { | |||
| 'is_locked': is_locked, | |||
There was a problem hiding this comment.
The template doesn't use this now, I think? If I'm right, we shouldn't pass it.
There was a problem hiding this comment.
Good catch, I remembered it appearing in other places but that must have been other templates. Will remove.
rjsparks
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4272