Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agenda): fallback link to plaintext version #4663

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

NGPixel
Copy link
Member

@NGPixel NGPixel commented Oct 27, 2022

Adds fallback links to loading screen and error screen:
image

image

Fixes #4655

@NGPixel NGPixel requested a review from rjsparks October 27, 2022 20:42
@NGPixel NGPixel changed the title feat: agenda fallback link to plaintext version feat(agenda): fallback link to plaintext version Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #4663 (7775025) into main (d34e88d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4663      +/-   ##
==========================================
- Coverage   88.43%   88.40%   -0.03%     
==========================================
  Files         296      296              
  Lines       39716    39730      +14     
==========================================
+ Hits        35122    35123       +1     
- Misses       4594     4607      +13     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.52% <100.00%> (ø)
ietf/utils/timezone.py 91.17% <100.00%> (+6.17%) ⬆️
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️
ietf/group/utils.py 93.72% <0.00%> (-0.90%) ⬇️
ietf/doc/views_search.py 89.44% <0.00%> (-0.83%) ⬇️
ietf/nomcom/utils.py 90.77% <0.00%> (-0.49%) ⬇️
ietf/utils/mail.py 79.62% <0.00%> (-0.47%) ⬇️
ietf/submit/forms.py 82.70% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larseggert
Copy link
Collaborator

Nice fix. I just wish we wouldn't continue to build a ton of custom CSS instead of using b5. It will be a pain to move to newer bs versions.

@rjsparks rjsparks merged commit 9f8fd90 into ietf-tools:main Oct 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to txt agenda to top menu
3 participants