Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort higher capacity rooms first in schedule editor #4653

Merged

Conversation

jennifer-richards
Copy link
Member

In the meeting schedule editor, rooms were meant to be sorted in decreasing order of capacity (among other criteria). Due to a bug, they were actually sorted in increasing order. Oops.

This fixes that and also handles the case where capacity is None.

Partially addresses #4377 but there is probably further work to do there.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #4653 (981c3bf) into main (d34e88d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4653      +/-   ##
==========================================
- Coverage   88.43%   88.41%   -0.03%     
==========================================
  Files         296      296              
  Lines       39716    39730      +14     
==========================================
+ Hits        35122    35126       +4     
- Misses       4594     4604      +10     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.52% <ø> (ø)
ietf/utils/timezone.py 91.17% <100.00%> (+6.17%) ⬆️
ietf/doc/views_search.py 89.23% <0.00%> (-1.04%) ⬇️
ietf/group/utils.py 93.72% <0.00%> (-0.90%) ⬇️
ietf/utils/mail.py 79.62% <0.00%> (-0.47%) ⬇️
ietf/submit/forms.py 82.70% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit a3673f2 into ietf-tools:main Oct 27, 2022
@jennifer-richards jennifer-richards deleted the jennifer/rooms-without-capacity branch October 27, 2022 15:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants