Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return False from has_role() when role_names is the empty list #4541

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

jennifer-richards
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #4541 (07b0fb4) into main (d3f25a6) will increase coverage by 0.00%.
The diff coverage is 86.00%.

@@           Coverage Diff           @@
##             main    #4541   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files         296      296           
  Lines       39674    39679    +5     
=======================================
+ Hits        35086    35092    +6     
+ Misses       4588     4587    -1     
Impacted Files Coverage Δ
ietf/ietfauth/utils.py 92.76% <50.00%> (+2.02%) ⬆️
ietf/doc/utils.py 88.12% <66.66%> (-0.46%) ⬇️
ietf/api/views.py 89.06% <100.00%> (+0.17%) ⬆️
ietf/doc/views_doc.py 90.88% <100.00%> (+0.34%) ⬆️
ietf/doc/views_search.py 89.44% <100.00%> (+0.20%) ⬆️
ietf/group/forms.py 91.41% <100.00%> (+0.16%) ⬆️
ietf/ipr/views.py 87.69% <100.00%> (ø)
ietf/meeting/views.py 90.78% <100.00%> (ø)
ietf/nomcom/utils.py 91.28% <100.00%> (-0.17%) ⬇️
ietf/nomcom/views.py 96.73% <100.00%> (+<0.01%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit cb9e576 into ietf-tools:main Oct 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
@jennifer-richards jennifer-richards deleted the jennifer/query-objects branch October 11, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants