Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add table dividers #4417

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

larseggert
Copy link
Collaborator

And add some ­ hyphens while we're here.

And add some ­ hyphens while we're here.
@larseggert
Copy link
Collaborator Author

There is https://django-softhyphen.readthedocs.io/en/latest/, but that says

(Warning! Because of its overhead, the filter is not recommended in production if it needs to run each time the page loads.)

@rjsparks
Copy link
Member

rjsparks commented Sep 7, 2022

how badly do you need those hyphens at the moment? Could you back out that part of the change for now and we can investigate just how bad the performance overhead of django-softhyphen really is?

@larseggert
Copy link
Collaborator Author

I'll take them out. They do make the layout on narrower screens break, since the table flows past the leftmenu, but that is minor.

@larseggert
Copy link
Collaborator Author

Note that https://github.com/datadesk/django-softhyphen is archived and hasn't seen a commit in seven years...

@rjsparks
Copy link
Member

rjsparks commented Sep 8, 2022

Thanks.

If we can't find a library someone else is supporting I would rather set up our own dict in utils for the words we want to soft-hyphenate and a template filter that would transform words using that dict than to manually, explicitly, soft-hyphenate each word each time it occurs. The latter raises the readability concern I already pointed to, and would likely lead to things like making programs scanning for spelling errors literals break.

@rjsparks rjsparks merged commit 228b496 into ietf-tools:main Sep 8, 2022
@larseggert larseggert deleted the add-table-dividers branch September 8, 2022 14:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants