-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add table dividers #4417
ui: Add table dividers #4417
Conversation
And add some ­ hyphens while we're here.
There is https://django-softhyphen.readthedocs.io/en/latest/, but that says
|
how badly do you need those hyphens at the moment? Could you back out that part of the change for now and we can investigate just how bad the performance overhead of django-softhyphen really is? |
I'll take them out. They do make the layout on narrower screens break, since the table flows past the leftmenu, but that is minor. |
Note that https://github.com/datadesk/django-softhyphen is archived and hasn't seen a commit in seven years... |
Thanks. If we can't find a library someone else is supporting I would rather set up our own dict in utils for the words we want to soft-hyphenate and a template filter that would transform words using that dict than to manually, explicitly, soft-hyphenate each word each time it occurs. The latter raises the readability concern I already pointed to, and would likely lead to things like making programs scanning for spelling errors literals break. |
And add some hyphens while we're here.