Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont serialize Submission.first_two_pages through /api/v1. #4145

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Jul 1, 2022

Fixes #4083

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only concern was whether the makeresources management command will interact with this. I think it will ignore models that already have resources even if those differ from what it would generate, but thought I'd raise this just in case my understanding is incorrect.

@rjsparks
Copy link
Member Author

rjsparks commented Jul 6, 2022

dev ➜ /workspace (no2pages@api ✗) $ ietf/manage.py makeresources submit

Inspecting ietf.submit ..
  nothing to do for ietf.submit

@rjsparks rjsparks merged commit 2934ae2 into ietf-tools:main Jul 6, 2022
@rjsparks rjsparks deleted the no2pages@api branch July 6, 2022 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 api crashes on some content when serializing to xml
2 participants