Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid mutables as default arguments. Compute date default arguments at runtime rather than loadtime. #4144

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Jul 1, 2022

Fixes #4141

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #4144 (b559986) into main (7de5d93) will increase coverage by 0.00%.
The diff coverage is 94.44%.

@@           Coverage Diff           @@
##             main    #4144   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         295      295           
  Lines       39164    39201   +37     
=======================================
+ Hits        34548    34581   +33     
- Misses       4616     4620    +4     
Impacted Files Coverage Δ
ietf/api/serializer.py 76.02% <60.00%> (-0.63%) ⬇️
ietf/nomcom/utils.py 91.17% <66.66%> (-0.23%) ⬇️
ietf/doc/utils.py 87.58% <100.00%> (+0.08%) ⬆️
ietf/meeting/views.py 91.15% <100.00%> (+0.01%) ⬆️
ietf/person/templatetags/person_filters.py 79.48% <100.00%> (+1.10%) ⬆️
ietf/review/utils.py 89.55% <100.00%> (+0.04%) ⬆️
ietf/stats/views.py 88.79% <100.00%> (+0.09%) ⬆️
ietf/utils/mail.py 79.57% <100.00%> (+0.49%) ⬆️
ietf/utils/test_smtpserver.py 81.25% <100.00%> (ø)
ietf/group/utils.py 93.69% <0.00%> (-0.91%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7d468...b559986. Read the comment docs.

@rjsparks rjsparks merged commit b988850 into ietf-tools:main Jul 6, 2022
@rjsparks rjsparks deleted the defaultparams branch July 6, 2022 19:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad default parameter in doc.utils.has_same_ballot
2 participants